fix: Multiple improvements + docs update #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
commented
Oct 25, 2021
tido64
reviewed
Oct 25, 2021
|
It's ready for re-review. I haven't touch the code regarding error handling, since it handles all platforms equally. If you'd rather not throw the same error for every batched |
tido64
approved these changes
Nov 3, 2021
krizzu
force-pushed
the
android-improvements
branch
from
cfd7639 to
dab59bc
Compare
krizzu
commented
Nov 4, 2021
|
🎉 This PR is included in version 1.15.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
|
Where are you seeing that Room 2.4.0 requires compileSdk 31? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sorry for pushing it into one PR. Got a couple of fixes/improvements coming:
Fixed the issue where
multiGetdid not propagate errors correctly, meaning they were just ignored. #634This also changes the way it handles the error from original design - previously, if we'd call many
multiGetfor different keys, they'll be batched into one native call. If any of them failed, the rest of them fail too, but, only the failed one will get the error message, while the rest will be resolved asundefinedvalues, creating false negatives. This is now changed, so that once one multiGet fails, every other batched call will throw the same error.Bumped the dependencies for Next storage (Kotlin, Room, Coroutines). #684
I tried to get everything to the latest version. Turns out, Room, with version 2.4.0 (where Apple M1 support is fixed) needs also increased
compileSdkversion bumped to 31 (latest one). It'd be bad for a library to dictate this version, so instead hardcoding it to 2.4.0, I made it 2.3.0. However, I added afeature flag, so that developer can set this version manually. (cc @Daavidaviid)Updated documentation
Since we had a few issues raised about size limits, I added a section in our documentation about it.